Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Garay #552

Merged
merged 29 commits into from
Oct 24, 2023
Merged

Garay #552

merged 29 commits into from
Oct 24, 2023

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Oct 3, 2023

[171-C18] Consensus: Accept 69 Garay characters in a new Garay block (U+10D40..U+10D8F) for encoding in a future version of the standard. (Reference L2/22-048)

Note that the proposed UnicodeData.txt lines have a duplicate code point, see bbfffdc. Added to unicode-org/properties#169.

After that change, checked consistency with Ken’s UnicodeData-16.0.0d6.txt and LineBreak-16.0.0d2.txt.

However, the invariant tests spotted an issue in UnicodeData: the Garay digits were given ccc equal to their numeric value‼️
Added to unicode-org/properties#169 and corrected.

Changed the reduplication mark and the vowel length mark to Lm.

@eggrobin
Copy link
Member Author

eggrobin commented Oct 3, 2023

CI does not pass because of collation.

@roozbehp
Copy link
Contributor

roozbehp commented Oct 3, 2023

This also needs Script Extensions properties added for Arabic comma, question mark, and semicolon (see the proposal, Section 4).

Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eggrobin eggrobin marked this pull request as ready for review October 9, 2023 14:56
@markusicu markusicu self-assigned this Oct 16, 2023
unicodetools/data/ucd/dev/PropList.txt Outdated Show resolved Hide resolved
unicodetools/data/ucd/dev/PropList.txt Outdated Show resolved Hide resolved
unicodetools/data/ucd/dev/PropList.txt Outdated Show resolved Hide resolved
unicodetools/data/ucd/dev/PropList.txt Show resolved Hide resolved
@eggrobin eggrobin requested a review from markusicu October 23, 2023 12:28
markusicu
markusicu previously approved these changes Oct 23, 2023
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eggrobin eggrobin merged commit cab2fa7 into unicode-org:main Oct 24, 2023
9 of 10 checks passed
eggrobin added a commit to eggrobin/unicodetools that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants